Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated task card UI #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

updated task card UI #19

wants to merge 4 commits into from

Conversation

pratikagr
Copy link
Contributor

Changes card design
-changed color of card for better readability
-makes the font size bigger
-gives spaces to the text in card(padding)

@Him-anshuSharma
Copy link
Collaborator

hey @pratikagr can you attach some screenshots?

@pratikagr
Copy link
Contributor Author

Screenshot 2022-10-10 094220
hey @pratikagr can you attach some screenshots?

@Him-anshuSharma
Copy link
Collaborator

Him-anshuSharma commented Oct 10, 2022

@pratikagr Hey
remove that hello task card from the top of listview builder and set the initial route to splashscreen.id from home_screen.dart.

@pratikagr
Copy link
Contributor Author

@pratikagr Hey remove that hello task card from the top of listview builder and set the initial route to splashscreen.id from home_screen.dart.

done

Copy link
Collaborator

@Shubhi-Paul Shubhi-Paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The card size is fixed, some topics need less space while few need extra. The height should be dynamic to fit accordingly.
  2. The font is too large , so only few tasks can fit on the screen.
  3. Display all the topics in capital.

Also : Make the pr in UI branch not master branch.

@pratikagr
Copy link
Contributor Author

pratikagr commented Oct 12, 2022

Screenshot 2022-10-12 113754
-Height is dynamic
-font size is decreased
-what topic?

i am doing PR in main branch not master.

],
child: MaterialApp(
title: "10,000 Hours",
initialRoute: splashScreen.id,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial route is the Onboarding screen

initialRoute: splashScreen.id,
routes: {

splashScreen.id: (context) => splashScreen(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its SplashScreen and not splashScreen , please check the errors , also add the OnbaordingScreen .

});
}),
),
CustomButton(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presently there is a Custom button and FloatingActionButton to do the same thing . Please choose one of the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants